fixed --depmap-project-info for scala sources with the same package_prefix

Review Request #990 — Created Sept. 4, 2014 and submitted

fkorotkov
pants
d633fc2...
pants-reviews
ity, jcoveney, tejal

fixed --depmap-project-info for scala sources with the same package_prefix

the problem was that we were using same current_target for all collected source roots. not the proper target this root is part of.

tests are passing

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
TE
  1. 
      
  2. i am confused with this test.
    Shouldnt the java target base be included in the package prefix?

    1. there should be 2 source roots with the same prefixes. one for scala and one for java. there is no assertion for the paths because they are always different due to test is executed in some random folder in temp.

  3. 
      
TE
  1. 
      
  2. You can assert the path using self.build_root.

    self.build_root will point to the temporary buildroot.

    self.build_root/.pants.d/ is the pants workdir.

    In your test,
    '%s/java/project_info/BUILD' % self.build_root and
    '%s/project_info/BUILD' % self.build_root will be created.

  3. 
      
FK
FK
  1. ping

  2. 
      
TE
  1. Ship It!

  2. 
      
FK
FK
FK
Review request changed

Status: Closed (submitted)

Loading...