Add IntelliJ content type to project Info. Add missing resources to targets.

Review Request #964 - Created Aug. 29, 2014 and submitted

Information
Tejal Desai
pants
7afb975...
Reviewers
pants-reviews
ity, jcoveney

Add IntelliJ content type to project Info. Add missing resources to targets.

This is required for intelliJ pants plugin to correctly mark the source, resource, test target and test resources.

The constants are defined here in IntelliJ
http://grepcode.com/file_/repository.grepcode.com/java/ext/com.jetbrains/intellij-idea/13.0.0/com/intellij/openapi/externalSystem/model/project/ExternalSystemSourceType.java/?v=source

Locally ./pants tests/python/pants_test/tasks:depmap passes

https://travis-ci.org/pantsbuild/pants/builds/33880605

Issues

  • 2
  • 0
  • 1
  • 3
Description From Last Updated
Depmap should not know about intellij (what about eclipse, ensime, ...). Its fine for it to know about the concepts ... John Sirois John Sirois
better to refer to https://github.com/JetBrains/intellij-community Fedor Korotkov Fedor Korotkov
Fedor Korotkov
Stu Hood
Tejal Desai
Tejal Desai
Review request changed

Status: Closed (submitted)

John Sirois

   

Depmap should not know about intellij (what about eclipse, ensime, ...). Its fine for it to know about the concepts each of these constants represents though. So I think this is minor in-practice but it is a concept leak and should be fixed. Please pick a neutral class name and leave no association with any IDE or the strings it expects, just leave constants documented here (no pointing to DIEA docs). The various consumers of this neutral metadata can then interpret and map as they specifically see fit.

Fedor Korotkov

   

better to refer to https://github.com/JetBrains/intellij-community

Loading...