Add IntelliJ content type to project Info. Add missing resources to targets.

Review Request #964 — Created Aug. 29, 2014 and submitted

tejal
pants
7afb975...
pants-reviews
ity, jcoveney

Add IntelliJ content type to project Info. Add missing resources to targets.

This is required for intelliJ pants plugin to correctly mark the source, resource, test target and test resources.

The constants are defined here in IntelliJ
http://grepcode.com/file_/repository.grepcode.com/java/ext/com.jetbrains/intellij-idea/13.0.0/com/intellij/openapi/externalSystem/model/project/ExternalSystemSourceType.java/?v=source

Locally ./pants tests/python/pants_test/tasks:depmap passes

https://travis-ci.org/pantsbuild/pants/builds/33880605

  • 2
  • 0
  • 0
  • 1
  • 3
Description From Last Updated
Depmap should not know about intellij (what about eclipse, ensime, ...). Its fine for it to know about the concepts ... JS jsirois
better to refer to https://github.com/JetBrains/intellij-community FK fkorotkov
FK
  1. 
      
  2. src/python/pants/backend/jvm/tasks/depmap.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     

    move one level up next to resource_target_map and rename current_target to target.

    it's a bit confusing to have it in process_target

    1. Kind of disagree. I want to limit the scope of the method to process_target.

      Will change the current_target to target.

  3. 
      
ST
  1. 
      
  2. Can move the url from your comment in the review description (about where these are defined) to here.

  3. 
      
TE
TE
Review request changed

Status: Closed (submitted)

JS
  1. 
      
  2. Depmap should not know about intellij (what about eclipse, ensime, ...). Its fine for it to know about the concepts each of these constants represents though. So I think this is minor in-practice but it is a concept leak and should be fixed. Please pick a neutral class name and leave no association with any IDE or the strings it expects, just leave constants documented here (no pointing to DIEA docs). The various consumers of this neutral metadata can then interpret and map as they specifically see fit.

  3. 
      
FK
  1. 
      
  2. better to refer to https://github.com/JetBrains/intellij-community

  3. 
      
Loading...