Fixed source roots in project info for IntelliJ plugin in case of ScalaLibrary with java_sources

Review Request #955 — Created Aug. 28, 2014 and submitted

fkorotkov
pants
35bfb0e...
pants-reviews
ity, jcoveney, tejal

Fixed source roots in project info for IntelliJ plugin in case of ScalaLibrary with java_sources

I haven't managed to run ci but ran test_depmap.py separatly. It's passing.

FK
TE
  1. 
      
  2. You can also check isinstance(current_target, ScalaLibrary).

    ScalaLibrary property java_sources will return an empty list if no java_sources are defined.

    1. thanks. with isinstance PyCharm even provides a completion :-)

      empty list is ok. tests are passing.

  3. 
      
FK
TE
  1. Ship It!

  2. 
      
FK
TE
  1. in order to run ci on travis,

    Just push your branch to origin.

    and then go to web ui https://travis-ci.org/pantsbuild/pants

    You would see the ci job for your pushed branch.

    To run ci locally:
    ./build-support/bin/ci.sh

    Thanks
    Tejal

    1. thanks! it's passing

  2. 
      
ST
  1. 
      
  2. src/python/pants/backend/jvm/tasks/depmap.py (Diff revision 2)
     
     
     
     
     
     
     
     
     

    This is definitely awkward... can we add a TODO here linking to some of the proposals for how to fix the circular dep betweem java/scala sources?

    1. There is issue which i opened with proposal for removing java sources. There was some discussion on pants devel group on this.

      https://github.com/pantsbuild/pants/issues/65

  3. 
      
IT
  1. lgtm, sans other comments.

  2. 
      
FK
TE
  1. Ship It!

  2. 
      
FK
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/c077a3d3d5c645fcbfcd0801d361cd97b0d92782
Loading...