Re-enable filedeps - it was using a now-gone .expand_files() API.

Review Request #939 - Created Aug. 26, 2014 and submitted

Information
John Sirois
pants
jsirois/issues/437
437, 522
d52b9d8...
Reviewers
pants-reviews
jinfeng, patricklaw

commit 1a54a4180ba9c264046235f96c1170249d3ce5bf
Author: John Sirois <jsirois@twitter.com>
Date: Mon Aug 25 16:56:56 2014 -0700

Re-enable filedeps - it was using a now-gone .expand_files() API.

This maintains a hack with special knowledge of the JvmApp target and
adds one more to deal with ScalaLibrary.java_sources.

Both of these hacks have unit-test coverage to help back up future
refactors away from these hacks.

src/python/pants/backend/jvm/tasks/BUILD | 3 +
src/python/pants/backend/jvm/tasks/filedeps.py | 34 ++++++++-
tests/python/pants_test/tasks/BUILD | 14 ++++
tests/python/pants_test/tasks/test_base.py | 2 +-
tests/python/pants_test/tasks/test_filedeps.py | 203 ++++++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 252 insertions(+), 4 deletions(-)

$ PANTS_DEV=1 ./pants goal test tests/python/pants_test/:all

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/33652015

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
John Sirois
Ity Kaul
Jin Feng
Patrick Lawson
John Sirois
John Sirois
Patrick Lawson
John Sirois
John Sirois
John Sirois
John Sirois
Ity Kaul
Patrick Lawson
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...