filter tests:: --filter-ancestor=-blacklist:blacklist ain't working. try to fix
Review Request #925 — Created Aug. 20, 2014 and submitted
filter tests:: --filter-ancestor=-blacklist:blacklist ain't working. try to fix add a test for this case the problem: at the time the ancestor filter does its thing, the blacklist:blacklist target doesn't "realize" it has deps. My hazy understanding: we added blacklist:blacklist to the build graph, but didn't tell it to, uhm, recurse its deps. I think this change tells it to recurse its deps. And I guess that's what we want here. But I don't necessarily know about better approaches, silly repercussions, etc.
After you add in your unwanted target: self.assert_console_output( 'blacklist:blacklist', 'common/b:b', 'common/b:foo', 'common/c:c', 'common/c:foo', targets=self.targets('common/::') # blacklist is in the list of targets ) Also, I am working to enable --exclude-target-regexp so that it will work with filter and list goals and filter out targets before we try to inject them in the build graph.