Clean up almost all extant uses of the obsolete term 'phase'.

Review Request #910 — Created Aug. 18, 2014 and submitted

benjyw
pants
pants-reviews
lahosken
The only remaining ones are in builddictionary.py and its test,
goals_reference.mustache, and various .rst files.
Ran all unit and integration tests. CI baking.
LA
  1. Speaking of the build dictionary, is this 'phase' gonna remain?
    
    src/python/pants/backend/core/register.py:      'phase': Goal,
    
    If yes, then OK.
    
    If no, then it would be good to add an entry to builddictionary.py's PREDEFS to point folks at the new thing to use. Like what we did for java_tests:
    
      "java_tests": {"defn": msg_entry("java_tests",
                      """Old name for `junit_tests`_"""),},
    
    (trying to remember if this is already in some other RB... it might be... mentioning it again here just in case)
    1. I want to make that change in a separate commit, because I'm not sure what the implications are (or why that name is available in BUILD files in the first place). Ideally it should never have been there and we can nuke it without deprecation in the builddicttionary. 
  2. 
      
LA
  1. 
      
  2. src/python/pants/base/workunit.py (Diff revision 1)
     
     
    whew, it's a relief these aren't used in more places :-)
  3. 
      
BE
Review request changed

Status: Closed (submitted)

Change Summary:

Thanks for the quick review!
Loading...