Add a whitelist to jvm dependency analyzer

Review Request #888 - Created Aug. 13, 2014 and submitted

Information
Johan Oskarsson
pants
2c51f2c...
Reviewers
pants-reviews
benjyw, jsirois, patricklaw, stuhood

The whitelist allows big repos to reduce dependency issues while stopping any new from being introduced. You can whitelist the projects that currently have issues and make the dependency checks fatal. All projects with current issues will still be able to build but new issues will result in breaking builds.

Also it seems like the direct dependency check would always fatal if set to fatal, fixed that.

Added two integration tests.

Issues

  • 1
  • 1
  • 0
  • 2
Description From Last Updated
These two tests are almost identical... make one toplevel test with a private/local helper method? Stu Hood Stu Hood
Benjy Weinberger
Eric Ayers
Stu Hood
John Sirois
Patrick Lawson
Johan Oskarsson
Review request changed

Status: Closed (submitted)

Larry Hosken

seeing Travis-CI failure that looks like missing deps
in missingdepswhitelist2/MissingDepsWhitelist2.java
https://travis-ci.org/pantsbuild/pants/builds/35652819

e.g., /home/travis/build/pantsbuild/pants/testprojects/src/java/com/pants/testproject/missingdepswhitelist2/MissingDepsWhitelist2.java:3: error: package com.pants.examples.hello.greet does not exist

Looking now. Wouldn't mind the answer on a silver platter, tho.

Larry Hosken

Mmmaybe it's surprising that CI is trying to build this testproject code at all? Like, ...maybe this change's testproject/ code is supposed to be broken?

  1. I'm hitting the error you hit Larry on a branch that changes how ci.sh selects unit and integration test targets. I'll be sorting this issue in order to get my branch in a reviewable state if no-one figures the issue out 1st.

  2. https://rbcommons.com/s/twitter/r/1049/

Loading...