Do we want the java sources used in the test to be in src/ or in test/? Or example/? Or a new source root? I really don't think they belong in src/ although I know there are other sources there already, so I wouldn't hold up this change on that. Maybe worth discussing on pants-devel.
Looks like you don't need this import.
Add a whitelist to jvm dependency analyzer
Review Request #888 — Created Aug. 13, 2014 and submitted
|benjyw, jsirois, patricklaw, stuhood|
The whitelist allows big repos to reduce dependency issues while stopping any new from being introduced. You can whitelist the projects that currently have issues and make the dependency checks fatal. All projects with current issues will still be able to build but new issues will result in breaking builds.
Also it seems like the direct dependency check would always fatal if set to fatal, fixed that.
Added two integration tests.
|These two tests are almost identical... make one toplevel test with a private/local helper method?||ST stuhood|
It would be nice to add some documentation. I suggest adding it under the 'compile' goal under src/python/pants/doc/goals_reference.rst We haven't been all that great about documenting config settings but when cmdline ops and ini settings converge it should get easier.
Sorry for the late review! lgtm
Fixes the issues brought up. Will merge this as is due to the shipits.
seeing Travis-CI failure that looks like missing deps
e.g., /home/travis/build/pantsbuild/pants/testprojects/src/java/com/pants/testproject/missingdepswhitelist2/MissingDepsWhitelist2.java:3: error: package com.pants.examples.hello.greet does not exist
Looking now. Wouldn't mind the answer on a silver platter, tho.
Mmmaybe it's surprising that CI is trying to build this testproject code at all? Like, ...maybe this change's testproject/ code is supposed to be broken?