Allow the buildroot to be a subdirectory of the git worktree

Review Request #886 - Created Aug. 14, 2014 and submitted

Information
Stu Hood
pants
405
Reviewers
pants-reviews
jsirois, lahosken, patricklaw
This allows the buildroot to be a subdirectory of the git worktree, which supports a usecase we have internally where two pants builds will live within the same git repo for a while until they can be merged.

- Add a class method to attempt to detect a git worktree
- Report changed_files relative_to some directory (usually the buildroot)
- confirmed that files outside the relative_to path/directory are ignored
- added test for worktree detection at various levels of nesting
- `./pants goal changed` and `./pants goal bundle` succeed in a buildroot below the worktree root (and in existing projects)

Issues

  • 2
  • 5
  • 1
  • 8
Description From Last Updated
Any reason this isn't the default? Patrick Lawson Patrick Lawson
Again it'd be nice to have `get_buildroot()` be the default Patrick Lawson Patrick Lawson
Larry Hosken
Patrick Lawson
David Turner
Stu Hood
Stu Hood
Patrick Lawson
John Sirois
Stu Hood
Review request changed

Status: Closed (submitted)

Loading...