Add pep425 tagging support to twitter.common.python

Review Request #87 — Created March 10, 2014 and submitted

wickman
commons
pants-reviews
patricklaw, skumaran, travis
This adds PEP425 tag iteration to twitter.common.python:
http://legacy.python.org/dev/peps/pep-0425/

Wheel platform tags are encoded in this fashion and is the standardized way to determine whether or not a wheel distribution is compatible with the current platform.


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
TR
  1. In general this looks reasonable, but I'm learning about this platform-specific python packaging.
    
    The main thing that jumps out here is we should doc the new stuff. In particular, we're expecting to parse specially formatted strings and we should define what those strings are expected to look like. Otherwise, Future Selves will come across this code and have a harder time understanding it.
    1. is the link to the pep insufficient?
  2. """
    :param name: The description. Note this line is not indented from the triple quotes.
    :returns: like this, not as a separate line.
    """
    1. I'm just learning sphinx doc tagging but all the docs I've found are (ironically) terrible.  Do you have any links?  The best one I've found is http://sphinx-doc.org/markup/desc.html but it's light on examples.
  3. 
      
PA
  1. Ship It!
  2. 
      
WI
TR
  1. Ship It!
  2. 
      
WI
Review request changed

Status: Closed (submitted)

Loading...