Upgrade to pants 0.0.23

Review Request #864 — Created Aug. 11, 2014 and submitted

jsirois
commons
jsirois/pants/upgrade
321
pants-reviews
areitz, stuhood, wickman
NB: This picks up from the discarded https://rbcommons.com/s/twitter/r/827/

commit e185c4df90346c4e2ff5e4d77601d39308c3e26b
Author: John Sirois <jsirois@twitter.com>
Date:   Mon Aug 11 16:30:16 2014 -0600

    Upgrade to pants 0.0.23
    
    This also prepares a twitter.common.pants plugin release.

 pants                                                                |  2 +-
 pants-plugins/3rdparty/BUILD                                         |  2 +-
 pants-plugins/src/python/twitter/common/pants/BUILD                  |  2 +-
 pants-plugins/src/python/twitter/common/pants/CHANGELOG.rst          | 10 ++++++++++
 pants-plugins/src/python/twitter/common/pants/jvm/args/register.py   |  8 +++-----
 pants-plugins/src/python/twitter/common/pants/jvm/extras/register.py | 14 ++++++--------
 6 files changed, 22 insertions(+), 16 deletions(-)
$ ./build-support/bin/ci.sh
JS
JS
JS
JS
  1. Mostly green CI, metrics flakes on 1 of 2 shards: https://travis-ci.org/twitter/commons/builds/32280553
  2. 
      
AR
  1. LGTM, although I'm largely ignorant of twitter.commons.
  2. What is the replacement for this? Or is it just not needed anymore?
    1. s/not needed/not supported/ - the replacement concept is to use a native mechanism, like pytest-timeout annotations.  I did not do so here though - I'm just letting the test hang to indicate failure.  Travis will time out the build, local devs will complain with a stuck CLI - and at that point we can fix if we hit that point.
  3. 
      
JS
  1. Thanks - submitted @ https://github.com/twitter/commons/commit/e150a90b45414b144f64ad20339167a604c9ff2b
    twitter.common.pants 0.5.0 published here: https://pypi.python.org/pypi/twitter.common.pants/0.5.0
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...