Use JvmFingerprintStrategy in cache manager

Review Request #835 - Created Aug. 5, 2014 and submitted

Information
Johan Oskarsson
pants
Reviewers
pants-reviews
jsirois, patricklaw, stuhood
JvmFingerprintStrategy was not used for the cache manager, causing the valid analysis file to be emptied the second time a compile was executed. 
Added a basic java compile integration test. Calls pants compile on a java test project twice, checking that the analysis file is valid each time. The sanity and approach here should probably undergo extra scrutiny. Unsure what the pythony way of doing "if workdir is specified use, otherwise with temporary_dir", so split that into two methods.

I will attempt to add a unit test too when I cleanup the old extra_data code.

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
This comment belongs on def workdir_root(), no? Benjy Weinberger Benjy Weinberger
Since this field is used in multiple methods, I'd feel much more comfortable if it was initialized in the constructor. Stu Hood Stu Hood
Benjy Weinberger
Stu Hood
John Sirois
Patrick Lawson
Johan Oskarsson
Review request changed

Status: Closed (submitted)

Loading...