A specialized container for option values.

Review Request #815 — Created Aug. 1, 2014 and submitted

benjyw
pants
pants-reviews
patricklaw
This container supports key forwarding and ranked values. See docstrings
for details.


PA
  1. 
      
  2. src/python/pants/option/ranked_value.py (Diff revision 1)
     
     
    Any particular reason these aren't just public instance attributes?  Is this thing intended to be subclassed and tweaked, or are you just protecting against a mistaken overwrite of the attribute?
  3. src/python/pants/option/ranked_value.py (Diff revision 1)
     
     
    Should this class be hashable?  Should it be ordered?
  4. 
      
BE
  1. 
      
  2. src/python/pants/option/ranked_value.py (Diff revision 1)
     
     
    Just to "ensure" immutability.
  3. src/python/pants/option/ranked_value.py (Diff revision 1)
     
     
    I thought about that, but decided against. The rank ordering is only a partial order, and a full ordering doesn't really make sense.
    
    I didn't want to make this more complicated than it needs to be, although hashability is not a bad idea. I can add that in a future change.
  4. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...