Create a mixin for "quiet tasks".

Review Request #806 — Created July 31, 2014 and submitted

benjyw
pants
pants-reviews
patricklaw
This separates the two concerns formerly handled by ConsoleTask:
being quiet, and being a task whose primary job is to print to the console.

Now you mix in QuietTaskMixin for the first, and extend ConsoleTask
(which itself mixes in QuietTaskMixin) for the second.

This rids us of silliness such as the clean-all task having a flag
to specify its output separator.


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
PA
  1. lgtm other than the question about stderr/stdout
  2. Should this be stdout or stderr?  Also if you're tweaking this anyway, it might be a good idea to use format interpolation.
    1. I prefer local consistency over global consistency. So I'll punt until we want to switch entire files over to format interpolation (which, btw, I hate- the % operator is super-convenient, and 'format' just adds verbosity, but I guess we're stuck with it).
      
      Good point, stderr makes sense. Fixed.
  3. 
      
BE
Review request changed

Status: Closed (submitted)

Loading...