Relativize classpath for non-ng java execution
Review Request #804 - Created July 31, 2014 and submitted
|jsirois, stuhood, tejal|
-Factored the classpath relativization logic into it's own module and reworked it slightly. -Made jmake relativize classpath in addition to the nailgun executor The jvm_utils BUILD file has an empty dependencies key to follow the convention I found in another file.
Ran a java/scala test target with nailgun enabled/disabled and made sure the classpath was minimized and the tests passed.
|I think you wanted to add this to JvmCompile||Tejal Desai|
This will work for any fileset, not just classpaths, right? Might want to find a location more relevant for "path/file" manipulation. Also, the inner method should probably move out and become public (if it doesn't already exist in whichever other file you find that is doing file/dir ops)
Does this need to happen for scala compiles as well?
how efficient is `+` on a large list? might consider templating these in rather than concatenating before the join
You added the dependency jvm_utils to 'src/python/pants/backend/jvm/tasks/jvm_compile:jvm_compile' target But added relative_utils functionality in src/python/pants/backend/jvm/tasks/jvm_compile/compile.py. That led me to thinking you meant to add this to JvmCompile => src/python/pants/backend/jvm/tasks/jvm_compile/java_compile.py. However, after read your comments to Stu's remark, add this dependency to 'src/python/pants/backend/jvm/tasks/jvm_compile:java'