`goal repl` should be transitive

Review Request #781 - Created July 29, 2014 and submitted

Information
Stu Hood
pants
Reviewers
pants-reviews
benjyw, jsirois, tejal
- Partition by selected language vs all other languages to allow for handling of 'dependencies'/'jar_library' and other inner nodes
- Filter the entire context, rather than just target roots
- Label JarLibrary as a JVM target (and fix related fallout)
new unit test
manual validation of mixed/scala/python contexts:

-----
PANTS_DEV=1 ./pants goal repl src/scala/com/pants/testproject/unicode
...
scala> com.pants.testproject.unicode.shapeless.ShapelessExample.greek()
res1: String = shapeless success

-----
PANTS_DEV=1 ./pants goal repl src/python/example/hello/greet
...
>>> from example.hello.greet.greet import greet
>>> greet("yo")
u'\x1b[32mHello, yo!\x1b[0m'
-----

PANTS_DEV=1 ./pants goal repl src/scala/com/pants/testproject/unicode src/python/example/hello/greet
...
FAILURE: Mutually incompatible targets specified: (at least) PythonLibrary(BuildFileAddress(/Users/stuhood/src/pants/src/python/example/hello/greet/BUILD, greet)) vs ScalaLibrary(BuildFileAddress(/Users/stuhood/src/pants/src/scala/com/pants/testproject/unicode/shapeless/BUILD, shapeless))

Issues

  • 1
  • 2
  • 0
  • 3
Description From Last Updated
This is a pretty big difference in functionality, and one that needs to be more fully discussed. The old code ... Benjy Weinberger Benjy Weinberger
Stu Hood
Stu Hood
John Sirois
Tejal Desai
Tejal Desai
Benjy Weinberger
Stu Hood
John Sirois
Stu Hood
Review request changed

Status: Closed (submitted)

Loading...