Fixup a hole in external dependency listing wrt encoding.

Review Request #776 - Created July 29, 2014 and submitted

Information
John Sirois
pants
jsirois/dup_check/more_decode_fixing
406
Reviewers
pants-reviews
benjyw, ity, jcoveney, johanoskarsson, patricklaw, stuhood, zundel
Refer to https://rbcommons.com/s/twitter/r/615/
This fixes a hole left there encountered at Twitter against ... shapeless.
It also adds an integration test that is now fixed with this fix.

commit 89848dc3438f8918a72f728cdc619e5bcfd10f3f
Author: John Sirois <jsirois@twitter.com>
Date:   Mon Jul 28 17:23:21 2014 -0600

    Fixup a hole in external dependency listing wrt encoding.
    
    This change also adds a previously failing example from the shapeless library
    to the integration test.

 src/java/com/pants/testproject/unicode/main/BUILD                        |  3 ++-
 src/java/com/pants/testproject/unicode/main/CucumberMain.java            |  2 ++
 src/python/pants/backend/jvm/tasks/detect_duplicates.py                  |  8 ++++----
 src/scala/com/pants/testproject/unicode/shapeless/BUILD                  | 15 +++++++++++++++
 src/scala/com/pants/testproject/unicode/shapeless/ShapelessExample.scala | 22 ++++++++++++++++++++++
 tests/python/pants_test/tasks/BUILD                                      |  2 ++
 tests/python/pants_test/tasks/test_detect_duplicates.py                  |  4 +---
 tests/python/pants_test/tasks/test_jvm_bundle_integration.py             | 30 +++++++++++++++++++-----------
 8 files changed, 67 insertions(+), 19 deletions(-)
Locally:
$ PANTS_DEV=1 ./pants goal test tests/python/pants_test:all
$ PANTS_DEV=1 ./pants goal test tests/python/pants_test/tasks:jvm_bundle_integration

Travis CI went green: https://travis-ci.org/pantsbuild/pants/builds/31093736

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
John Sirois
John Sirois
John Sirois
John Sirois
Stu Hood
John Sirois
Eric Ayers
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...