Force parsing for filtering specs

Review Request #775 — Created July 28, 2014 and submitted

stuhood
pants
pants-reviews
jsirois, zundel
get_target fails if the target has not been parsed as part of the context, or manually added. Need to force parsing for filtering specs, since they will likely not be included in the graph otherwise.
Passes existing tests, and resolves the issue internally.

Will follow up with a test for this issue in another review.
JS
  1. It should be pretty easy to augment this test: https://github.com/pantsbuild/pants/blob/master/tests/python/pants_test/tasks/test_filter.py#L165
    You just need a target added to the build graph in setUp thats disconnected and not listed in the CLI inputs.
    
    I know you're un gun, but I'll let you push back if that proves onerous.
  2. 
      
TE
  1. Ship It!
  2. 
      
ST
JS
  1. Thanks for the test Stu
  2. 
      
ZU
  1. Ship It!
  2. 
      
ST
Review request changed

Status: Closed (submitted)

Loading...