Plumb ivysettings.xml location to the publish template.

Review Request #764 — Created July 26, 2014 and submitted

jsirois
pants
jsirois/publish/streamline_config
400
pants-reviews
jinfeng, stuhood, tejal, zundel
commit 71b3b6f99b3f7cbb1020c027dc4a6b09d4573c79
Author: John Sirois <jsirois@twitter.com>
Date:   Fri Jul 25 16:38:50 2014 -0600

    Plumb ivysettings.xml location to the publish template.

 pants.ini                                         |  7 ++-----
 src/python/pants/backend/jvm/tasks/jar_publish.py | 15 +++++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)
1.) tests including publish integration
==
$ PANTS_DEV=1 ./pants goal test tests/python/pants_test/::

2.) local publish
==
$ yes | PANTS_DEV=1 ./pants goal publish src/{java,scala}:: --no-publish-dryrun --publish-local=/tmp/repo --doc-javadoc-ignore-failure --doc-scaladoc-ignore-failure
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
JS
  1. TRavis CI went green here: https://travis-ci.org/pantsbuild/pants/builds/30901117
  2. 
      
JS
JS
JI
  1. don't think i have enough knowledge/context to give a shipit :)
  2. 
      
ZU
  1. 
      
  2. pants.ini (Diff revision 1)
     
     
    I assume you are removing this because it is already the default, but I can't see where it comes from other than PANTS_IVY_SETTINGS_XML (which I don't have set) in bootstrapper.py
    1. Its from that env var or else [ivy]ivy_settings: https://github.com/pantsbuild/pants/blob/master/src/python/pants/ivy/bootstrapper.py#L110
      [jar-publish]ivy_settings was pure dup of [ivy]ivy_settings
    2. And that brings up a good point, the 3rd and final fallback is None - which Ivy handles but JarPublish does not (it should fail fast with no explicit ivysettings.xml because unlike resolve which uses the ivy.jar default ivysettings.xml resource for read, there are no publishable repositories defined in that resource for write.
      
      I'll send up a new diff to properly fail-fast in JarPublish.
  3. 
      
JS
JS
  1. New CI away here: https://travis-ci.org/pantsbuild/pants/builds/31004405
    1. And that went green
  2. 
      
ZU
  1. Ship It!
  2. 
      
JS
  1. Thanks Eric - submitted @ https://github.com/pantsbuild/pants/commit/ca95d0a9064d80bfaca621a6d5b0058778f83fa2
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...