Upgrade to twitter.common.python 0.6.0 and adjust to api change.

Review Request #746 - Created July 25, 2014 and submitted

Information
John Sirois
pants
jsirois/pex/upgrade
394
Reviewers
pants-reviews
dturner-tw, patricklaw, wickman
This came up over here: https://rbcommons.com/s/twitter/r/737/
I'll wait to submit until 0.6.0 gets published to pypi.

commit aee52bd9ae7bdb64e787a0de7e51e9eb5cd2909c
Author: John Sirois <jsirois@twitter.com>
Date:   Thu Jul 24 21:31:20 2014 -0600

    Upgrade to twitter.common.python 0.6.0 and adjust to api change.

 3rdparty/python/twitter/commons/requirements.txt | 2 +-
 pants.ini                                        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
In commons:
==
$ ./pants setup_py src/python/twitter/common/python
Running packager against /home/jsirois/dev/3rdparty/twitter-commons/dist/twitter.common.python-0.6.0
Writing /home/jsirois/dev/3rdparty/twitter-commons/dist/twitter.common.python-0.6.0.tar.gz


Then over here on top of the RB diff:
==
1.) $ cat 3rdparty/python/twitter/commons/requirements.test.txt
# To toggle to private releases, un-comment these search override flags and remove version
# constraints from the requirements below.

--find-links file:///home/jsirois/dev/3rdparty/twitter-commons/dist/
--no-index

twitter.common.python>=0.6.0,<0.7


2.) $ git diff
diff --git a/3rdparty/python/twitter/commons/BUILD b/3rdparty/python/twitter/commons/BUILD
index 1077c0e..c168c25 100644
--- a/3rdparty/python/twitter/commons/BUILD
+++ b/3rdparty/python/twitter/commons/BUILD
@@ -3,3 +3,5 @@
 
 # see/edit requirements.txt in this directory to change deps.
 python_requirements()
+
+python_requirements('requirements.test.txt')
diff --git a/3rdparty/python/twitter/commons/requirements.txt b/3rdparty/python/twitter/commons/requirements.txt
index 51e74ff..7c84c05 100644
--- a/3rdparty/python/twitter/commons/requirements.txt
+++ b/3rdparty/python/twitter/commons/requirements.txt
@@ -13,7 +13,7 @@ twitter.common.lang>=0.3.1,<0.4
 twitter.common.log>=0.3.1,<0.4
 twitter.common.options>=0.3.1,<0.4
 twitter.common.process>=0.3.1,<0.4
-twitter.common.python>=0.6.0,<0.7
+#twitter.common.python>=0.6.0,<0.7
 twitter.common.quantity>=0.3.1,<0.4
 twitter.common.string>=0.3.1,<0.4
 twitter.common.threading>=0.3.1,<0.4
diff --git a/build-support/pants_venv b/build-support/pants_venv
index 663ff9d..322a401 100755
--- a/build-support/pants_venv
+++ b/build-support/pants_venv
@@ -9,6 +9,7 @@ source ${REPO_ROOT}/build-support/set_archflags.sh
 REQUIREMENTS=(
   ${REPO_ROOT}/3rdparty/python/requirements.txt
   ${REPO_ROOT}/3rdparty/python/twitter/commons/requirements.txt
+  ${REPO_ROOT}/3rdparty/python/twitter/commons/requirements.test.txt
 )
 
 DEV_REQUIREMENTS=(


And finally all green through the self bootstrap, etc:
==
$ ./build-support/bin/ci.sh

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
David Turner
Patrick Lawson
Patrick Lawson
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...