Loosen up t.c.pants constraints.

Review Request #712 — Created July 22, 2014 and submitted

Information
jsirois
commons
jsirois/pants/flexible_dep_constraints
312
Reviewers
pants-reviews
areitz, stuhood 
commit 705a0c960c348a2c911edb60f424a07bc843e601
Author: John Sirois <jsirois@twitter.com>
Date:   Mon Jul 21 22:05:55 2014 -0600

    Loosen up t.c.pants constraints.
    
    The twitter.common.pants plugins were pinned hard to
    pantsbuild.pants==0.0.17 limiting the context they could be used in.
    
    Expand the scope of supported pants releases up to 0.1.0 even though
    this is likely to permissive.  The pantsbuild.pants distributions will
    probably continue to break various APIs until we hit 0.1.0 and being
    more permissive and then fixing the low bound on the range when the
    plugins break seems about the best we can do.
    
    This also preps an sdist release with a version bump.

 pants-plugins/3rdparty/BUILD                        | 2 +-
 pants-plugins/src/python/twitter/common/pants/BUILD | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
I tried this locally on a pantsbuild.pants==0.0.18 (aka recent OSS pants master) + twitter.common.pants==0.3.2 release that was failing due to a dep conflict and using twitter.common.pants==0.3.3 the conflict is fixed.
AR
areitz 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    




    
    This is confusing. I don't see 'twitter.common.pants' in the cheeseshop:

https://github.com/pantsbuild/cheeseshop/tree/gh-pages/third_party/twitter-commons/0da0aff8fc7cce4d2d3991e36bc13f021ec66133

So I don't see how pantsbuild/pants will be able to consume this change.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      After this hits master and I publish to the pypi cheeseshop, I'll copy it to ours for 3rdparty pants_internal only deps: https://svn.twitter.biz/science-binaries/home/pants_internal/third_party/python/
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Okay, John pointed out to me that this change is meant to affect pantsbuild/pants, rather our custom pants PEX that we use at Twitter consumes 'twitter.common.pants' directly.
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   





 AR





   

   







  

 



 

  


   

   

    
 
areitz


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   





 JS





   

   





  

 



 

  


   

   

    
 
jsirois


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Thanks - submitted @ https://github.com/twitter/commons/commit/60f2a876ab2686281adf785be4e8c7b906f402e1
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      And released to pypi: https://pypi.python.org/pypi/twitter.common.pants/0.3.3
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 JS





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   



  

  

   
   Loading...