We need to require resources_by_target for junit_run

Review Request #709 — Created July 22, 2014 and submitted

areitz
pants
pants-reviews
ity, jsirois, stuhood, tejal
We need to require resources_by_target for junit_run. This line appears to have been lost in John's commit:

https://github.com/pantsbuild/pants/commit/38d994a74f40e481f10a7dd90fbddeb0196f0b4a#diff-8603ca893539bade8d782040a56d85b8L492

In a separate review, we'll submit a test that exercises this code path. But for now, we want to unblock conversion efforts.
https://travis-ci.org/pantsbuild/pants/builds/30512238
ST
  1. Thanks Andy. I'll have a review out for the test shortly.
  2. src/python/pants/backend/jvm/tasks/junit_run.py (Diff revision 1)
     
     
     
     
     
    these are buddies
    1. Test over here: https://rbcommons.com/s/twitter/r/711/
    2. Actually, if you look at the original diff (linked in the description), it was separate. I think that the comment on line 495 applies to only the two classes of data that follow. Any other classes included are (logically) in a separate block. Going to leave it the way I have it here & submit.
  3. 
      
JS
  1. Nice find and how embarrassing!  
  2. 
      
IT
  1. looks good!
    1. looks it was there and got taken out recently, nice catch!
      
      diff --git a/src/python/pants/backend/jvm/tasks/junit_run.py b/src/python/pants/backend/jvm/tasks/junit_run.py
      index 102c9c9..7a602e6 100644
      --- a/src/python/pants/backend/jvm/tasks/junit_run.py
      +++ b/src/python/pants/backend/jvm/tasks/junit_run.py
         def prepare(self, round_manager):
      -    round_manager.require_data('resources_by_target')
      +    super(JUnitRun, self).prepare(round_manager)
  2. 
      
AR
Review request changed

Status: Closed (submitted)

TE
  1. Ship It!
  2. 
      
Loading...