nested class should use fully-qualified class name when referring to base class

Review Request #705 - Created July 20, 2014 and submitted

Information
Misho Krastev
pants
master
Reviewers
pants-reviews
This is a fix for issue #367

Objects of class BinaryNotFound can not be instantiated because the constructor does not qualify the class name with its parent when it invokes the constructor of the superclass.
./pants goal test tests/python/pants_test:all

FYI, the tests failed with the error below. I don't believe this tiny correction has anything to do with it. So I checked out master branch and tried again, same result. I saw suggestion to set PANTS_DEV=1 but that did not help either. 

                     tests/python/pants_test/base_test.py:112: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     configpath = '/tmp/tmpExxZm6_BUILD_ROOT/pants.ini'
                     defaults = None
                     
                         @staticmethod
                         def load(configpath=None, defaults=None):
                           """
                               Loads a Config from the given path, by default the path to the pants.ini file in the current
                               build root directory.  Any defaults supplied will act as if specified in the loaded config
                               file's DEFAULT section.  The 'buildroot', invoking 'user' and invoking user's 'homedir' are
                               automatically defaulted.
                             """
                           configpath = configpath or os.path.join(get_buildroot(), 'pants.ini')
                           parser = Config.create_parser(defaults=defaults)
                     >     with open(configpath) as ini:
                             parser.readfp(ini)
                     E       IOError: [Errno 2] No such file or directory: u'/tmp/tmpExxZm6_BUILD_ROOT/pants.ini'
                     
                     src/python/pants/base/config.py:131: IOError
                      9 failed, 361 passed, 1 xfailed in 8.82 seconds =
Larry Hosken
Misho Krastev
Review request changed

Status: Closed (submitted)

Change Summary:

https://github.com/pantsbuild/pants/commit/a86f44c5b141f02d7bc724cb44402f56b070a80b

Loading...