doc: committing someone else's change: not always straightforward

Review Request #699 — Created July 16, 2014 and submitted

lahosken
pants
pants-reviews
jsirois, zundel
'./rbt patch -c 123' doesn't always work... oh, that's the suggested procedure, whoopsie
I tried out some of the workaround steps. Didn't actually try pushing to origin, tho. For all I know, that would have revealed that I messed up an earlier step.
ZU
  1. 
      
  2. I don't know if you want to mention this, but I usually try to finagle the commit message to look like an rbt created one, adding the review URL, bugs fixed and cutting and pasting the text from the rbcommons review.
  3. 
      
LA
JS
  1. 
      
  2. consider this for kepping the whole block actual command line:
    
    git commit --author='Mateo Rodriguez <mateorod9@gmail.com>' -F - << EOF
    Erect megaphones.
    
    This paves support for turning the volume up to 11.
    
    Testing Done:
    tesselated the megaphones
    
    Bugs closed: 345
    
    Reviewed at https://rbcommons.com/s/twitter/r/123/
    EOF
  3. 
      
LA
LA
Review request changed

Status: Closed (submitted)

Loading...