Resurrected pants goal idea.

Review Request #695 - Created July 16, 2014 and submitted

Information
Garrett Malmquist
pants
garrett/idea-resurrection
349
Reviewers
pants-reviews
jsirois, zundel
This mostly involved updating outdated references, and making utility functions to mimick functionality refactored long ago.

Source and Javadoc jars are not mapped in, and I'm not quite sure how to get that working again. I'd appreciate any input on that matter.

The code in idea_gen and ide_gen isn't very clean, because it wasn't very clean in the first place. It would be good to go back at some point and tidy it up.

Idea gen is also much more efficient than it used to be, thanks to the round manager: it now avoids compiling or jarring anything, which saves tons of time. It would still be nice to include a flag to optionally disable codegen, but I'm not sure how (un)trivial that is at this juncture.
Added (passing) integration tests under tasks/test_idea_integration.py
Tests under tasks:integration pass.

Issues

  • 0
  • 8
  • 0
  • 8
Description From Last Updated
Eric Ayers
John Sirois
Eric Ayers
John Sirois
John Sirois
John Sirois
Ity Kaul
John Sirois
Garrett Malmquist
Review request changed

Status: Closed (submitted)

Eric Ayers
(I should be able to commit this when Garrett says he's all done)
  1. nm, I see John just did.
Loading...