Cleanup pants.ini keys involved in pants bootstrapping.

Review Request #69 — Created March 6, 2014 and submitted

jsirois
commons
jsirois/pants_py/clean_bootstrapping
240
pants-reviews
benjyw, travis, wickman
commit c090a415af5539a9f4dc7db0ea62133a6a7b8837
Author: John Sirois <jsirois@twitter.com>
Date:   Thu Mar 6 11:37:11 2014 -0700

    Cleanup pants.ini keys involved in pants bootstrapping.
    
    This is a result of building a clean, minimal chroot to built Twitter in-house pants.
    The change removes some now dead keys from commons pants.ini and inserts
    defaults for other keys such that no pants.ini contents at all are needed to build
     a pex from a pip installed pants.

 pants.ini                                             | 38 ++++++++-----------------------------
 src/python/twitter/pants/base/config.py               | 19 ++++++++++++++-----
 src/python/twitter/pants/base/run_info.py             | 13 ++++++++++++-
 src/python/twitter/pants/bin/pants_exe.py             |  2 +-
 src/python/twitter/pants/binary_util.py               |  2 +-
 src/python/twitter/pants/commands/BUILD               |  1 +
 src/python/twitter/pants/commands/goal.py             |  6 ++++--
 src/python/twitter/pants/goal/initialize_reporting.py |  3 ++-
 src/python/twitter/pants/goal/run_tracker.py          |  2 +-
 src/python/twitter/pants/python/BUILD                 | 11 +++++++++++
 src/python/twitter/pants/python/interpreter_cache.py  |  9 +++++++--
 src/python/twitter/pants/python/python_chroot.py      |  9 ++++-----
 src/python/twitter/pants/python/python_setup.py       | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/python/twitter/pants/python/resolver.py           |  7 +++++--
 14 files changed, 122 insertions(+), 51 deletions(-)
Confirmed the server tracked the jvm-only ci following its launch:
$ ./build-support/bin/ci.sh -j
$ ./pants goal server
$ ./build-support/bin/ci.sh -bps
JS
TR
  1. This looks good.
    
    Re: how this relates to https://rbcommons.com/s/twitter/r/67/ – this is very complimentary and we should ship this. One explicit goal of 67 is centralizing all the options so we can generate documentation about what's tunable. This change continues to keep the config file options scattered throughout the source tree, and I'd like to centralize that to the extent possible.
  2. 
      
JS
  1. I'm going to merge this since it introduces no whacky deps.  I suspect the objections I'd get would be on PythonSetup being a bit heavyweight and I'll circle back if you have comments there Brian.
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...