Enable Nailgun Per Task

Review Request #687 - Created July 16, 2014 and submitted

Information
Dan Davydov
pants
Reviewers
pants-reviews
benjyw, jsirois, stuhood, tejal
For discussion around this patch please see: https://groups.google.com/forum/#!searchin/pants-devel/nailgun/pants-devel/wcvYfUvhPeg/uyFfy6_IqPEJ

Note for antlr3 / antlr4 I made their ng-killall option under a new more generic [antlr] config section. Also note that any classes that extend NailgunTask must supply the config_section constructor parameter (otherwise when nailgun is attempted to be used it will fail), this is intentional (though this would obviously be better do to during compile time rather than run time).

Also did a bit of style/duplicate code refactoring.
Added print statements to nailgun/non-nailgun execution paths, and tested different combinations of pants configs:
-No use_nailgun flags (should always use nailgun)
-use_nailgun: False in [DEFAULT] (should never use nailgun)
-use_nailgun: False in [DEFAULT] and use_nailgun: True in [scala-compile] (nailgun was only used for scala)

Also
./build-support/ci.sh

Issues

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
You can use the same abstract property trick and let the subclasses define it. It looks much cleaner and also, ... Tejal Desai Tejal Desai
Stu Hood
Tejal Desai
Dan Davydov
John Sirois
Tejal Desai
Tejal Desai
John Sirois
John Sirois
Dan Davydov
Review request changed

Status: Closed (submitted)

Tejal Desai
yep. i could not mark it as submitted since it is not my review.

But i wasnt smart enough to comment on it :( mentioning it is submitted.
Loading...