Lock globs into rootdir and below

Review Request #686 - Created July 15, 2014 and submitted

Information
Johan Oskarsson
pants
348
Reviewers
pants-reviews
benjyw, jsirois
Currently if a user specifies something like the java_library glob below in a BUILD file it will silently be ignored by commons fileset in most cases. However it sometimes blows up (idea target or together with build cache):

java_library(name="y", sources=globs("../*.scala"))

This branch attempts to resolve that by simply explicitly not allowing it, failing the builds early if one is present.

The approach taken is to extend the wrapped globs to perform this check. This means anywhere using the globs will not be able to point outside the 'root'. Would this present a problem anywhere?
Local ci.sh passes (except for a few tests that don't pass on master).
Benjy Weinberger
John Sirois
Johan Oskarsson
Review request changed

Status: Closed (submitted)

Loading...