Fix the '--bundle-dup-excludes' flag and add '--bundle-dup-max-dups'

Review Request #656 — Created July 9, 2014 and submitted

zundel
pants
zundel/detect-duplicates-config
332
pants-reviews
ity, jsirois
Fix the '--bundle-dup-excludes' flag and add '--bundle-dup-max-dups'

Now the default output prints out how many more you get:

   Duplicate classes and/or resources detected in artifacts: (u'commons-beanutils-commons-beanutils-1.7.0.jar', u'commons-beanutils-commons-beanutils-core-1.8.0.jar')
                        org/apache/commons/beanutils/BeanAccessLanguageException.class
                        org/apache/commons/beanutils/converters/URLConverter.class
                        org/apache/commons/beanutils/locale/converters/IntegerLocaleConverter.class
                        org/apache/commons/beanutils/converters/CharacterArrayConverter.class
                        org/apache/commons/beanutils/MethodUtils.class
                        org/apache/commons/beanutils/converters/BooleanConverter.class
                        org/apache/commons/beanutils/converters/ClassConverter.class
                        org/apache/commons/beanutils/DynaBean.class
                        org/apache/commons/beanutils/converters/BooleanArrayConverter.class
                        org/apache/commons/beanutils/Converter.class
                        ... 123 more ...
I've got a lot of duplicate classes on the classpath to sort out...

devpants goal bundle <target> --bundle-dup-max-dups=50 --bundle-dup-excludes=dependencies,license,notice,.DS_Store,notice.txt,cmdline.arg.info.txt.1,license.txt,org.apache.hadoop.fs.FileSystem,BCKEY.DSA,BCKEY.SF,ASL2.0,javax.servlet.ServletContainerInitializer,about.html

ZU
JS
  1. Please add Ity as a reviewer - she is the original author of this check and will be happy to see improvements.
    1. Done. We have a lot of duplicate classes and I'm not sure I can just use 'jar().excludes()' to get rid of the warnings so I'll be exploring this some more.
  2. 
      
ZU
ZU
ZU
IT
  1. looks good - thanks for doing this!
  2. 
      
JS
  1. Ship It!
  2. 
      
ZU
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted at 7b12dfe7caef4e6b64b5309dd6fde210ac4e8ee4
Loading...