Fix missing java & scala product types for ScroogeGen.

Review Request #639 — Created July 8, 2014 and submitted

jsirois
pants
jsirois/scrooge/products
320
pants-reviews
ity
commit 33f967a21f18b0dfe8bd4b62fd3b64f5f429cb72
Author: John Sirois <jsirois@twitter.com>
Date:   Mon Jul 7 08:54:04 2014 -0700

    Fix missing java & scala product types for ScroogeGen.
    
    CodeGen handles this, but ScroogeGen is not a subclass.

 src/python/pants/backend/codegen/tasks/scrooge_gen.py | 4 ++++
 1 file changed, 4 insertions(+)
None.  I noticed this missing when working through RoundEngine validation improvements.
IT
  1. Ship It!
  2. 
      
JI
  1. 
      
  2. curious by missing this class method, what was the consequence?
    1. There was none as things stand.
      
      I noticed this when fixing the RoundEngine checks for circular and missing deps - see: https://rbcommons.com/s/twitter/r/644/
      The initial fix did tsort on the Tasks instead of the Phase nodes.  When tsorting this way, jvm tasks depending on codegen would get ApacheThriftGen and ProtobufGen (both subclass CodeGen) in their task graph but not ScroogeGen.  This is masked in the current tsort logic since the phases are wha'ts sorted and ScroogeGen is installend in the gen phase list of tasks and thus gets "pulled along" despite missing the declaration.
  3. 
      
JS
  1. Thanks folks - submitted @ https://github.com/pantsbuild/pants/commit/6e4ebfc62e2670d609adf28d72462a3aa6f293e4
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...