Kill Context.state - its no longer used nor should it be used again.

Review Request #625 — Created July 2, 2014 and submitted

jsirois
pants
jsirois/context/kill_state
313
pants-reviews
benjyw, ity
Context.state started off as a hack for classpath mutation by IvyResolve, JvmCompile Tasks and ResourcePrepare.
The hack of mutating a classpath has since moved to exclusive_groups mutation. 
This change does not address fixing the moved mutation, that's forthcoming in the remaining transformations set up by the RoundEngine changes.

commit 44c0bf3d34142ab4fde1a580c550be91edfb76f3
Author: John Sirois <jsirois@twitter.com>
Date:   Wed Jul 2 08:06:41 2014 -0600

    Kill Context.state - its no longer used nor should it be used again.

 src/python/pants/goal/context.py | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
CI ran green: https://travis-ci.org/pantsbuild/pants/builds/28965745
JS
BE
  1. I don't even know what that state was supposed to be, so LGTM.
  2. 
      
IT
  1. looks good!
  2. 
      
JS
  1. Thanks folks - submitted @ https://github.com/pantsbuild/pants/commit/7e45cf705858d0139cd6545fb7bcd24bbc793207
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...