Kill support for legacy scrooge.

Review Request #603 — Created June 27, 2014 and submitted

jsirois
pants
jsirois/scrooge/kill_legacy_support
288, 289
pants-reviews
ity, johanoskarsson, tejal
commit 35be6ce2749bcffbc80a796c555cf08190f82c1a
Author: John Sirois <jsirois@twitter.com>
Date:   Fri Jun 27 11:03:49 2014 -0600

    Kill support for legacy scrooge.
    
    This change punts on cleaning up the ScroogeGen task
    which now can be simplified a good deal.  The intent is
    just to remove the possibility of folks binding to this capability
    going forward.

 BUILD.tools                                                     |  5 -----
 pants.ini                                                       | 21 ---------------------
 src/python/pants/backend/codegen/targets/java_thrift_library.py | 12 +++---------
 src/python/pants/backend/codegen/tasks/scrooge_gen.py           | 13 ++++---------
 src/python/pants/thrift_util.py                                 | 24 ------------------------
 tests/python/pants_test/targets/test_java_thrift_library.py     |  8 --------
 6 files changed, 7 insertions(+), 76 deletions(-)
$ PANTS_DEV=1 ./pants goal test {src,tests}/{java,scala}::
$ PANTS_DEV=1 ./pants goal test tests/python/pants_test/:all
$ PANTS_DEV=1 ./pants goal test tests/python/pants_test/:integration
JS
JS
JS
  1. CI went green here: https://travis-ci.org/pantsbuild/pants/builds/28608598
  2. 
      
IT
  1. Ship It!
  2. 
      
TE
  1. Ship It!
  2. 
      
JS
  1. Thanks folks - submitted @ https://github.com/pantsbuild/pants/commit/f4d28923eaa579721601f7dca7ab014fac8f589a
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...