pants py: Only pay attention to top level PythonBinaries, not transitive PythonBinaries.

Review Request #57 — Created March 5, 2014 and submitted

wickman
commons
pants-reviews
jsirois, travis
The change to .resolve for PythonLibrary to extend to its binaries in the case it specified a PythonArtifact caused a regression with pants py.  How it manifested itself: pants py src/python/twitter/common/python would actually invoke src/python/twitter/common/python/bin:pex because it was a binary on the PythonArtifact.  This meant that I couldn't do pants py src/python/twitter/common/python to load it into the REPL as a library.

Tried to post to pants-reviews but it looks like it's not a recognized group alias in rbcommons yet (probably have to configure that I'm guessing.)


WI
  1. Ugh this doesn't fix it either:
    
    twitter.pants.python.python_chroot.InvalidDependencyException: Not a valid Python dependency! Found: JarLibrary(src/python/twitter/pants/BUILD:pants)
    
    Looking at how to resolve this...no pun..intended... 
  2. 
      
JS
  1. Another approach is to fall back a bit and let the folks that care about associated binaries deal with them instead of baking this into resolve - even if resolve is the right eventual home for this.  When I fixed the is_concrete issue I actually wanted to fix in this way but did not want to stall understanding who needed the knowledge.
  2. 
      
WI
WI
JS
  1. Ship It!
  2. 
      
LA
  1. Did this change go in? Kinda looks like it did, or something similar did.
    
    If it went in, I darez ya to Close -> Submitted
  2. 
      
WI
Review request changed

Status: Closed (submitted)

Loading...