archflags bug initial commit

Review Request #562 — Created June 17, 2014 and submitted

ajohnson
pants
pants-reviews
benjyw, jsirois
Fix for pants bootstrapping error caused by Wno-error=unused-command-line-argument-hard-error-in-future
./pants runs successfully
build-suppot/bin/ci.sh succeeds
  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
JO
  1. 
      
  2. build-support/set_archflags.sh (Diff revision 1)
     
     
    it would be nice to have a more comprehensive comment here about what the issue is and perhaps a link to the github issue (iirc we had one?)
  3. build-support/set_archflags.sh (Diff revision 1)
     
     
    Probably better to just silently skip it
  4. 
      
JS
  1. 
      
  2. build-support/set_archflags.sh (Diff revision 1)
     
     
    We use 2 space indents in all other scripts IIRC.
  3. build-support/set_archflags.sh (Diff revision 1)
     
     
    This is not even true!  Its only true of OSX [sleekname].  The [sleekname] may be Mavericks.  Even then it depends on how the python in play was built - gcc or clang.  To do this right it would take an autoconf strength macro.  You might call the shot and sat this breaks old macs which is probably the simplest true thing to say thats right 90% of the time.
    1. Sorry about that! I just lifted this comment and the line below it straight from pants_venv. Perhaps a better comment would then be "#required with clang-503.0.38"? 
  4. 
      
JS
  1. Meta-comment, your @twitter.com email address appears to be getting DMARC bounced.  You'd be better off switching to a personal email address or contacting Chris A for a non-@twitter.com domain account.  We have some fancy open but twittery domain setup for twitter oss work.
  2. 
      
AJ
JO
  1. Ship It!
  2. 
      
TE
  1. 
      
  2. build-support/set_archflags.sh (Diff revision 2)
     
     
    you might as well mention the version.
    clang-503.0.38
  3. 
      
IT
  1. lgtm, just some style nits
  2. build-support/set_archflags.sh (Diff revision 2)
     
     
    > 100 chars.
    s/#p/# P
  3. build-support/set_archflags.sh (Diff revision 2)
     
     
    if [[ "$GCC_VERSION" == *503.0.38* ]]; then
      export
    fi
    
  4. build-support/set_archflags.sh (Diff revision 2)
     
     
    s/#r/# R
  5. 
      
AJ
TE
  1. Ship It!
  2. 
      
AJ
  1. Ship It!
  2. 
      
AJ
Review request changed

Status: Closed (submitted)

Loading...