Beef up the cotributor's howto a bit.

Review Request #51 — Created March 4, 2014 and submitted

jsirois
commons
jsirois/commons/doc_contrib
236
benjyw, lahosken, travis
Beef up the cotributor's howto a bit.

Add a section on vetting a change before diving in.

Add an addendum to the review posting section that outlines
how to preview CI results with the ci script.
$ ./pants goal builddict && cd src/python/twitter/pants/docs/ && ./gen.py

Then repeated rounds of:
$ make html

And browser refreshes.
LA
  1. Ship It!
  2. 
      
TR
  1. Ship It!
  2. 
      
BE
  1. Ship It!
  2. 
      
LA
  1. 
      
  2. (if we know where "github issues" live, a link would be lovely. if we're still figuring that out, no hurry)
    1. Sorry - just saw this.  I was fighting a publish_via_git.sh yak and decided to call it a draw and manually post-wrangle the html commit.
      The link is known: https://github.com/pantsbuild/pants/issues
      Technically though its still https://github.com/twitter/commons/issues for the next few weeks until migration to pantsbuild is real.
  3. 
      
JS
  1. Thanks guys - merged and published.
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...