Unbreak test_detect_duplicates.py and link into :all.

Review Request #484 — Created June 11, 2014 and submitted

jsirois
pants
jsirois/test_goal_fixups/test_detect_duplicates
204
pants-reviews
ity, patricklaw
commit 4c34ccaadb3f556b9fa885f950b40cf6c4682dc7
Author: John Sirois <jsirois@twitter.com>
Date:   Wed Jun 11 00:16:58 2014 -0600

    Unbreak test_detect_duplicates.py and link into :all.
    
    I think the test could be improved to be more black box and not dip
    in to test a private method directly, but this fixes the basic break
    due to a signature change in the tested private method.

 src/python/pants/backend/jvm/tasks/detect_duplicates.py | 10 ++++------
 tests/python/pants_test/tasks/BUILD                     |  4 +++-
 tests/python/pants_test/tasks/test_detect_duplicates.py | 39 ++++++++++++++++++++++-----------------
 3 files changed, 29 insertions(+), 24 deletions(-)
$ PANTS_DEV=1 ./pants goal test tests/python:: --test-pytest-options="-v -ktest_detect_duplicates"
...
00:15:23 00:01   [test]
00:15:23 00:01     [pytest]
00:15:23 00:01       [run]
                     ============== test session starts ===============
                     platform linux3 -- Python 2.6.8 -- py-1.4.20 -- pytest-2.5.2 -- /home/jsirois/dev/3rdparty/pyenv/versions/2.6.8/bin/python
                     plugins: cov, timeout
                     collected 282 items 
                     
                     tests/python/pants_test/tasks/test_detect_duplicates.py:68: DuplicateDetectorTest.test_duplicate_found PASSED
                     tests/python/pants_test/tasks/test_detect_duplicates.py:73: DuplicateDetectorTest.test_duplicate_not_found PASSED
                     tests/python/pants_test/tasks/test_detect_duplicates.py:78: DuplicateDetectorTest.test_fail_fast_error_raised PASSED
                     
                      279 tests deselected by '-ktest_detect_duplicates' 
                     ==== 3 passed, 279 deselected in 0.83 seconds ====
                     
00:15:25 00:03     [junit]
00:15:25 00:03     [specs]
               SUCCESS
PA
  1. Ship It!
  2. 
      
IT
  1. Ship It!
  2. 
      
JS
  1. Thanks folks - submitted at https://github.com/pantsbuild/pants/commit/c3e8c29ced8166f8730e4d4a568c6dec08483859
  2. 
      
JS
Review request changed

Status: Closed (submitted)

Loading...