Prepare the 1.3.0dev1 release.

Review Request #4383 — Created Nov. 16, 2016 and submitted

jsirois
pants
jsirois/prepare_release/1.3.0dev1
4062
5119b8f...
pants-reviews
cheister, kwlzn, mateor, stuhood
CONTRIBUTORS.md                   |   8 ++-
 src/python/pants/notes/master.rst | 167 ++++++++++++++++++++++++++++++++++++++++++++++++++
 src/python/pants/version.py       |   2 +-
 3 files changed, 173 insertions(+), 4 deletions(-)

I tested the ability of a release to consume the native engine binary
from bintray via:

$ ./build-support/bin/release.sh -n
$ virtualenv -p python2.7 /tmp/pants
$ source /tmp/pants/bin/activate
$ pip install -f dist/ pantsbuild.pants==1.3.0dev1
$ mkdir /tmp/repo
$ cd /tmp/repo
$ touch pants pants.ini
$ pants --enable-v2-engine list ::
...
INFO] Attempting to fetch native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine ...
100% .................................................. 3961 KB 3.332s
INFO] Fetched native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine .
...

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/176468919

ST
  1. Thanks a lot for everything you did to prep this!

  2. CONTRIBUTORS.md (Diff revision 1)
     
     
     
     
     

    ...funky...? Not a huge deal, but I don't see how this will be stable.

    1. Yeah, I have no clue. Its powered by sort in build-support/bin/contributors.sh and I have:

      $ locale | grep -i collate
      LC_COLLATE="en_US.UTF-8"
      

      I'm going to leave as-is for now, favoring machine generated over hand curated, but agreed it would be good to somehow ensure collations are consistent.

  3. 
      
KW
  1. Ship It!
  2. 
      
MA
  1. I have concerns about shipping the node change in 85174866852aa1387cb34a7cdfd1f6642b6480c4, but it doesn't affect Foursquare. https://github.com/pantsbuild/pants/issues/4051

    I will reach out to @yic about what we should do in advance of Friday release. Thanks for getting this out, John.

  2. 
      
JS
JS
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit e8e731f5cf2bc1c331949fb2597e13dbe461a515
Author: John Sirois <john.sirois@gmail.com>
Date:   Wed Nov 16 13:22:29 2016 -0800

    Prepare the 1.3.0dev1 release.
    
    Testing Done:
    I tested the ability of a release to consume the native engine binary
    from bintray via:
    ```
    $ ./build-support/bin/release.sh -n
    $ virtualenv -p python2.7 /tmp/pants
    $ source /tmp/pants/bin/activate
    $ pip install -f dist/ pantsbuild.pants==1.3.0dev1
    $ mkdir /tmp/repo
    $ cd /tmp/repo
    $ touch pants pants.ini
    $ pants --enable-v2-engine list ::
    ...
    INFO] Attempting to fetch native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine ...
    100% .................................................. 3961 KB 3.332s
    INFO] Fetched native-engine binary from: https://dl.bintray.com/pantsbuild/bin/build-support/bin/native-engine/linux/x86_64/27e0016cfd490ba89830d6e99c93764c4357c268/native-engine .
    ...
    ```
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/176468919
    
    Bugs closed: 4062
    
    Reviewed at https://rbcommons.com/s/twitter/r/4383/
Loading...