Split test_zinc_compile_integration into two smaller tests

Review Request #4365 - Created Nov. 10, 2016 and submitted

Information
Peiyu Wang
pants
4044
Reviewers
pants-reviews
benjyw, ity, mateor, nhoward_tw, stuhood, wisechengyi, zundel

zinc_compile_integration is approaching its timeout and the upcoming zinc upgrade adds a few more seconds
from the first compile of the uncached compiler-interface.

Rather than increasing the timeout, this review splits into two separate tests.

Before (23 tests total):

tw-mbp-peiyu:pants peiyu$ pt tests/python/pants_test/backend/jvm/tasks/jvm_compile/zinc:zinc_compile_integration -- -v
...
                     collecting ... collected 23 items
...
                     ========== 23 passed in 354.06 seconds ===========

After (12 + 11 tests total):

tw-mbp-peiyu:pants peiyu$ pt tests/python/pants_test/backend/jvm/tasks/jvm_compile/zinc:zinc_compile_integration_with_zjars -- -v
...
                     collecting ... collected 12 items
...                     
                                          ========== 12 passed in 185.92 seconds ===========

...
tw-mbp-peiyu:pants peiyu$ pt tests/python/pants_test/backend/jvm/tasks/jvm_compile/zinc:zinc_compile_integration -- -v
...
                     collecting ... collected 11 items
...
                     ========== 11 passed in 177.04 seconds ===========

https://travis-ci.org/peiyuwang/pants/builds/174861353

Nick Howard (Twitter)
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as 0b224ca13023f935ba04539dc7dd4447eff8ebde

Loading...