Remove safe_mkdir on results_dir in [resolve.node]

Review Request #4362 - Created Nov. 9, 2016 and submitted

Information
Yi Cheng
pants
Reviewers
pants-reviews
benjyw, jsirois, mateor, stuhood, zundel
  • safe_mkdir(vt.results_dir) is redundant as vt.results_dir points to somewhere valid already, which should also be empty to start with, so there is no need to empty them again.
  • Using safe_mkdir may cause Exception message: [Errno 1] Operation not permitted: '/Users/yic/workspace/source/.pants.d/resolve/node/252d64521cf9/<target.id>/current'

https://travis-ci.org/pantsbuild/pants/builds/174423106
https://travis-ci.org/pantsbuild/pants/builds/174568355

  • Manual testing to make sure exception does not occur.
John Sirois
Yujie Chen
Nick Howard (Twitter)
Roger Jiang
Yi Cheng
Yi Cheng
Review request changed

Status: Closed (submitted)

Change Summary:

85174866852aa1387cb34a7cdfd1f6642b6480c4. thanks gents!

Loading...