Remove safe_mkdir on results_dir in [resolve.node]

Review Request #4362 — Created Nov. 9, 2016 and submitted

wisechengyi
pants
pants-reviews
benjyw, jsirois, mateor, stuhood, zundel
  • safe_mkdir(vt.results_dir) is redundant as vt.results_dir points to somewhere valid already, which should also be empty to start with, so there is no need to empty them again.
  • Using safe_mkdir may cause Exception message: [Errno 1] Operation not permitted: '/Users/yic/workspace/source/.pants.d/resolve/node/252d64521cf9/<target.id>/current'

https://travis-ci.org/pantsbuild/pants/builds/174423106
https://travis-ci.org/pantsbuild/pants/builds/174568355

  • Manual testing to make sure exception does not occur.
JS
  1. Ship It!
  2. 
      
YU
  1. You can also remove the dependency of "src/python/pants/util:dirutil" in BUILD.

    1. Corrected. Thanks Yujie!

  2. 
      
NH
  1. Ship It!
  2. 
      
RO
  1. Ship It!
  2. 
      
WI
WI
Review request changed

Status: Closed (submitted)

Change Summary:

85174866852aa1387cb34a7cdfd1f6642b6480c4. thanks gents!

Loading...