First round of native engine feedback

Review Request #4359 - Created Nov. 7, 2016 and submitted

Information
Stu Hood
pants
4037
Reviewers
pants-reviews
benjyw, jsirois, kwlzn, nhoward_tw

Applies the review feedback from r/4270, and fixes one minor issue with the bootstrap script.

  • exit 1 in build-support/bootstrap_native if compilation fails. This allows for iterating on e.g. ./pants --enable-v2-engine list .. until the native code successfully builds.
  • Used git-ls-files to determine which files to hash.
  • Derive/implement Default for Key/Value.
  • Whitespace in generic parameter lists.
  • Allow for visualizing executions to a directory via a --native-engine-visualize-to=$dir option.
  • Convert EntryId to a sealed type to avoid accidental random values.
  • Improve a few comments.
  • Suffix python keywords rather than prefixing them.
  • Whitespace fixes.
  • Silenced known unused code warning for 4020.
  • Attempt to cache ~/.cargo in travis.
  • Don't nuke $HOME in hermetic tests.

https://travis-ci.org/pantsbuild/pants/builds/173991370

John Sirois
Stu Hood
Stu Hood
Stu Hood
John Sirois
Stu Hood
Stu Hood
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 09650a1e4e1f5ead484c4d16abc181cf8d9e88b3

Loading...