Improve python_binary target fingerprinting.

Review Request #4353 - Created Nov. 4, 2016 and submitted

Information
Kris Wilson
pants
4028
Reviewers
pants-reviews
jsirois, stuhood, yujiec

This repairs a user-reported caching bug seen in our repo related to python_binary targets and caching. With caching turned on, adding zip_safe=False to an existing, already built/cached python_binary target will produce a stale binary that does not properly enable the zip_safe flag as expected, leading to user confusion.

Summary:

  • Add Payload fields for PythonBinary attributes.
  • Add a test case that breaks without this change and passes after.
  • Add some improved logging for payload/task/target fingerprinting for easier field debugging of similar issues.
  • Add fingerprint=True to a couple of key python-repos options to improve options fingerprinting behavior.

CI is green: https://travis-ci.org/pantsbuild/pants/builds/173540934

+ local testing against a repro in our repo.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Kris Wilson
Kris Wilson
John Sirois
Yujie Chen
Kris Wilson
John Sirois
Kris Wilson
Kris Wilson
Review request changed

Status: Closed (submitted)

Change Summary:

thanks John & Yujie! this is submitted @ https://github.com/pantsbuild/pants/commit/d88e7595485d87071e8a1678a27b76f0fe2f3bc8

Loading...