normalize filespec exclude usage
Review Request #4348 - Created Nov. 2, 2016 and submitted
|Nick Howard (Twitter)|
|benjyw, stuhood, yujiec|
Sometimes we use exclude and sometimes we use excludes. It looks like there might be bugs do to that. This patch ensures all of the glob and filespec related exclude names use exclude and not excludes.
Wrote a couple regression tests for the only bug I saw remaining and made them pass.
Revert exception message change. After looking it over, I like the original wording better. Should fix CI. Fixed broken tests locally.
Revision 2 (+42 -29)