[python-ng] A task to select a python interpreter.
Review Request #4346 — Created Nov. 1, 2016 and submitted
| Information | |
|---|---|
| benjyw | |
| pants | |
| Reviewers | |
| pants-reviews | |
| jsirois | |
Places the resulting interpreter in products for future python-ng tasks to consume. Also made a few changes to the old PythonTask, namely moving some logic that really belonged in InterpreterCache to there (so that the new task can use it), and removing some unused methods.
CI passes: https://travis-ci.org/pantsbuild/pants/builds/173577121
BE
Testing Done: |
|
||||||
|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+261 -43) |
JS
-
-
-
-
src/python/pants/backend/python/tasks2/select_interpreter.py (Diff revision 3) How about just use PythonInterpreter as the product type? There is no need to stick to strings as a middleman that I can see.
-
tests/python/pants_test/backend/python/tasks2/test_select_interpreter.py (Diff revision 3) It would be good to also exercise the no target case you took care to handle in the task code.
BE
Change Summary:
Address code review comments.
BE
Change Summary:
Make a test pass.
Testing Done: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+258 -44)
|