[python-ng] A task to select a python interpreter.
Review Request #4346 - Created Nov. 1, 2016 and submitted
| Information | |
|---|---|
| Benjy Weinberger | |
| pants | |
| Reviewers | |
| pants-reviews | |
| jsirois | |
Places the resulting interpreter in products for future python-ng tasks to consume. Also made a few changes to the old PythonTask, namely moving some logic that really belonged in InterpreterCache to there (so that the new task can use it), and removing some unused methods.
CI passes: https://travis-ci.org/pantsbuild/pants/builds/173577121
John Sirois
Review request changed
Review request changed
Testing Done: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+261 -43)
|
-
src/python/pants/backend/python/targets/BUILD (Diff revision 3) -
kill name
-
src/python/pants/backend/python/tasks2/BUILD (Diff revision 3) -
old habits - kill name and sources
-
src/python/pants/backend/python/tasks2/select_interpreter.py (Diff revision 3) -
How about just use PythonInterpreter as the product type? There is no need to stick to strings as a middleman that I can see.
-
tests/python/pants_test/backend/python/tasks2/test_select_interpreter.py (Diff revision 3) -
It would be good to also exercise the no target case you took care to handle in the task code.
Review request changed
Change Summary:
Address code review comments.
Diff: |
Revision 4 (+258 -44)
|
|---|
Ship It!
Review request changed
Change Summary:
Make a test pass.
Testing Done: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+258 -44)
|