thanks for tackling these Yujie! a couple of questions below.
looking at this diff and the test just above this one (which appears to set itself up identically but uses
--changed-diffspec), I'd expect their outputs to be the same - yet they aren't. why is that?
was this meant to be temporary?
Fix exlucde_target_regexp breakage in test-changed and --files option breakage in changed with diffspec
Review Request #4321 — Created Oct. 17, 2016 and submitted
|3977, 3981, 3982|
|kwlzn, mateor, stuhood|
This review addresses 2 issues:
1. Currently, on v1 engine, exclude_target_regexp does not have effect in test-changed (and also compile-changed since they have same base class).
2. In "changed" task, if both --diffspec and --files options are given, no output is printed.
This review fixes the above 2 issues and adds test coverage. I also add "ensure_engine" decorator to some tests in changed_integration.py which are currently only tested on v1 engine.
I am kind of rubber stamping the coverage b/c I have to run. I will test the next rc against my repros as it gets released. Thanks for closing the issues for us!