Fix exlucde_target_regexp breakage in test-changed and --files option breakage in changed with diffspec

Review Request #4321 - Created Oct. 17, 2016 and submitted

Information
Yujie Chen
pants
3977, 3981, 3982
Reviewers
pants-reviews
kwlzn, mateor, stuhood

This review addresses 2 issues:
1. Currently, on v1 engine, exclude_target_regexp does not have effect in test-changed (and also compile-changed since they have same base class).
2. In "changed" task, if both --diffspec and --files options are given, no output is printed.

This review fixes the above 2 issues and adds test coverage. I also add "ensure_engine" decorator to some tests in changed_integration.py which are currently only tested on v1 engine.

https://travis-ci.org/pantsbuild/pants/builds/168473439

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Kris Wilson
Mateo Rodriguez
Yujie Chen
Yujie Chen
Review request changed

Status: Closed (submitted)

Change Summary:

Merged in https://github.com/pantsbuild/pants/commit/6b34ffab020036fdd85543440415d97b5f4395b6.
Thanks Kris and Mateo!

Loading...