Remove the long-deprecated Target.is_codegen().

Review Request #4318 - Created Oct. 16, 2016 and submitted

Information
Benjy Weinberger
pants
Reviewers
pants-reviews
jsirois, kwlzn, tejal, zundel

Replace all calls with calls to Target.is_synthetic().

In pretty much all cases where we need to check if a target is a codegen
target, what we actually care about is whether that target was synthesized
in order to hold generated code. If didn't use target synthesis as an
implementation detail, we probably wouldn't have needed those is_codegen
checks to begin with.

This is an alternative to https://rbcommons.com/s/twitter/r/4316/ only one
of these will be submitted, hopefully this one, which is simpler.

CI passes: https://travis-ci.org/pantsbuild/pants/builds/168398072

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Eric Ayers
Yi Cheng
John Sirois
Benjy Weinberger
Benjy Weinberger
Stu Hood
Benjy Weinberger
Benjy Weinberger
Benjy Weinberger
Review request changed

Status: Closed (submitted)

Change Summary:

042725beb2151ceddc821defa07b77c4508e91d9

Loading...