Fix the SetupPy target ownership check.

Review Request #4315 - Created Oct. 15, 2016 and submitted

Information
John Sirois
pants
jsirois/python/publish/fix_ownership_check
3968, 3969
3a022b9...
Reviewers
pants-reviews
benjyw, kwlzn
Previously the check was too restrictive and considered targets that did
not own files when the single publish ownership check is only intended
to prevent publishing the same file in more than one package.

 src/python/pants/backend/python/tasks/setup_py.py             | 14 ++++++------
 tests/python/pants_test/backend/python/tasks/test_setup_py.py | 58 ++++++++++++++++++++++++++++++++++++++++++++++++--
 2 files changed, 64 insertions(+), 8 deletions(-)

Tested this over in Aurora ad-hoc and it solved the publish problem
there as well as passing the new test emulating the Aurora prep_command
arrangement.

CI went green here:
https://travis-ci.org/pantsbuild/pants/builds/169610485

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Benjy Weinberger
John Sirois
Benjy Weinberger
Stu Hood
Kris Wilson
John Sirois
John Sirois
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Change Summary:

Now on master:

git log -1 origin/master
commit 0abade1c40309ad63d22d17cef9e301aa9b8f8c6
Author: John Sirois <john.sirois@gmail.com>
Date:   Sat Oct 22 16:23:10 2016 -0400

    Fix the SetupPy target ownership check.
    
    Previously the check was too restrictive and considered targets that did
    not own files when the single publish ownership check is only intended
    to prevent publishing the same file in more than one package.
    
    Testing Done:
    Tested this over in Aurora ad-hoc and it solved the publish problem
    there as well as passing the new test emulating the Aurora `prep_command`
    arrangement.
    
    CI went green here:
      https://travis-ci.org/pantsbuild/pants/builds/169610485
    
    Bugs closed: 3968, 3969
    
    Reviewed at https://rbcommons.com/s/twitter/r/4315/
Loading...