Version clarification

Review Request #4299 — Created Oct. 12, 2016 and submitted

wisechengyi
pants
3954
pants-reviews
benjyw, mateor, nhoward_tw, stuhood, zundel

We usually attach some number before the release tag for our internal release, such as 12345.1.2.0rc0, but with https://rbcommons.com/s/twitter/r/4200 prepending a number would not work anymore.

This change adds some tests to clarify the behavior. To specify a custom version, postfix -<some number>

https://travis-ci.org/pantsbuild/pants/builds/167185997

BE
  1. Ship It!
  2. 
      
MA
  1. We had to really grind to find a solution that worked for both the Pants version parsing and pip resolution from our wheelhouse.
    I thought there was a general sense that adding a hyphen confused resolution in some cases?

    FWIW, we ended up with ${upstream_version}+${custom_version}
    * e.g. "pants_version: 1.1.0+fsq20160621155826

    This all predated the switch from 1.1.0-dev5 to 1.1.0dev5, so maybe those reasons no longer apply.

  2. 
      
WI
Review request changed

Status: Closed (submitted)

Change Summary:

7f54e2b9289bab41d3f0c37d45a367aeed2ab574 thanks gents!

Loading...