[engine] Allow injecting of intrinsic providers to ease testing

Review Request #4263 - Created Sept. 26, 2016 and submitted

Information
Nick Howard (Twitter)
pants
3905
Reviewers
pants-reviews
kwlzn, stuhood, yujiec

It's currently a little hard to test the interactions between task rules and intrinsics because they are injected directly by the NodeBuilder. This change allows the intrinsic providers
to be overridden for testing.

I also added an error condition if two intrinsics have the same key.

It seems a little big, but that's mostly due to the moving of the intrinsic rule class declarations.

CI passed at https://travis-ci.org/pantsbuild/pants/builds/162879047, I ran engine tests locally.

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Nick Howard (Twitter)
Nick Howard (Twitter)
Yi Cheng
Nick Howard (Twitter)
Yi Cheng
Stu Hood
Kris Wilson
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as https://github.com/pantsbuild/pants/commit/3d41b7bb430b298ed17c104988959757ef6ddee8
Loading...