[engine] When requesting select nodes or regular nodes, return state values rather than requiring a separate call
Review Request #4261 - Created Sept. 26, 2016 and submitted
|Nick Howard (Twitter)|
|jsirois, kwlzn, stuhood, yujiec|
Currently, when ever a selector is being resolved, the node calls
StepContext#getwith the result without doing much with the node value. The same is also somewhat true of
This replaces usages of
select_for, which returns just the state.
It also replaces
The other structural change is that
DependenciesNodenow iterates over the subject-variant tuples instead of the nodes generated.
The motivation here is to move away from exposing nodes for selectors to the node implementations.
Ran engine tests locally. CI away on the PR.
add [engine] to summary
Fix append / extend bug. Add assert to Waiting.
Revision 3 (+46 -53)