Clean up analysis.tmp usage between pants and zinc wrapper (Part 2)

Review Request #4246 - Created Sept. 19, 2016 and submitted

Information
Peiyu Wang
pants
3667, 3887
4245
Reviewers
pants-reviews
benjyw, jsirois, molsen, nhoward_tw, stuhood, zundel

This review and rb/4245 eliminates
.analysis.tmp's usage in pants, hides its creation and renaming with a
SafeFileBasedStore, so between pants and zinc the analysis file is always
valid, we wouldn't end up with pants passing to zinc inconsistent .analysis.tmp
and .analysis files, which contributes to https://github.com/pantsbuild/pants/issues/3667
See rb/4245 for more details.

(zinc tool version is bump to 0.0.4 to include https://rbcommons.com/s/twitter/r/4245/)

https://travis-ci.org/peiyuwang/pants/builds/161136974
https://travis-ci.org/peiyuwang/pants/builds/161798885

Issues

  • 0
  • 1
  • 1
  • 2
Description From Last Updated
Benjy Weinberger
Benjy Weinberger
Stu Hood
Peiyu Wang
Peiyu Wang
Stu Hood
Peiyu Wang
Peiyu Wang
Review request changed

Status: Closed (submitted)

Change Summary:

Merged as 8d4dde130bc3d6e84bf56eb8250035db598fafa2

Loading...