[engine] Move subselectors to selector properties

Review Request #4235 - Created Sept. 13, 2016 and submitted

Information
Nick Howard (Twitter)
pants
3867
Reviewers
pants-reviews
kwlzn, stuhood, yujiec

Select/Dependency/ProjectionNodes cause sub-selectors to be generated in order to select different products. This moves those selectors onto the selectors instead of having the nodes construct them directly.

Working on the new validation / graph creation, I find myself needing those sub-selectors in a few other places, so I wanted to give them consistent names.

Ran engine tests locally. CI away in PR.

Yujie Chen
Nick Howard (Twitter)
Stu Hood
Kris Wilson
Nick Howard (Twitter)
Review request changed

Status: Closed (submitted)

Change Summary:

Submitted as https://github.com/pantsbuild/pants/commit/1d096907cae1f729ff3abcff3b144df43df65af9
Loading...